Add more_info URL to text output #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outputting bandit report as text does not put `more_info` URL while it would if the output format is YAML or JSON. This patch set adds the `more_info` URL to the text display. Signed-off-by: Tin Lam <tin@irrational.io>
ghugo
approved these changes
Aug 7, 2018
ericwb
requested changes
Aug 7, 2018
bandit/formatters/text.py
Outdated
| @@ -27,6 +27,8 @@ | |||
| >> Issue: [B301:blacklist_calls] Use of unsafe yaml load. Allows | |||
| instantiation of arbitrary objects. Consider yaml.safe_load(). | |||
|
|
|||
| More Info: https://bandit.readthedocs.io/en/latest/ | |||
There was a problem hiding this comment.
Can you move the more info below the location? That would be more consistent with other formatters.
bandit/formatters/text.py
Outdated
| @@ -81,6 +84,9 @@ def _output_issue_str(issue, indent, show_lineno=True, show_code=True, | |||
| bits.append("%s>> Issue: [%s:%s] %s" % ( | |||
| indent, issue.test_id, issue.test, issue.text)) | |||
|
|
|||
| bits.append("%s More Info: %s" % ( | |||
| indent, docs_utils.get_url(issue.test_id))) | |||
|
|
|||
ericwb
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputting bandit report as text does not put
more_infoURL while itwould if the output format is YAML or JSON. This patch set adds the
more_infoURL to the text display.Signed-off-by: Tin Lam tin@irrational.io