Add more_info URL to csv formatter #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch set adds more_info URL to the csv formatter. Closes: PyCQA#323 Signed-off-by: Tin Lam <tin@irrational.io>
ericwb
requested changes
Aug 9, 2018
bandit/formatters/csv.py
Outdated
| @@ -24,10 +24,10 @@ | |||
| .. code-block:: none | |||
|
|
|||
| filename,test_name,test_id,issue_severity,issue_confidence,issue_text, | |||
| line_number,line_range | |||
| more_info,line_number,line_range | |||
There was a problem hiding this comment.
I think more_info should be listed after the line_range. That should help those that may be parsing the CSV with the introduction of a new column.
bandit/formatters/csv.py
Outdated
| examples/yaml_load.py,blacklist_calls,B301,MEDIUM,HIGH,"Use of unsafe yaml | ||
| load. Allows instantiation of arbitrary objects. Consider yaml.safe_load(). | ||
| ",5,[5] | ||
| ",https://bandit.readthedocs.io/en/latest/,5,[5] |
bandit/formatters/csv.py
Outdated
| @@ -63,14 +65,17 @@ def report(manager, fileobj, sev_level, conf_level, lines=-1): | |||
| 'issue_severity', | |||
| 'issue_confidence', | |||
| 'issue_text', | |||
| 'more_info', | |||
| 'line_number', | |||
| 'line_range'] | |||
bandit/formatters/csv.py
Outdated
| examples/yaml_load.py,blacklist_calls,B301,MEDIUM,HIGH,"Use of unsafe yaml | ||
| load. Allows instantiation of arbitrary objects. Consider yaml.safe_load(). | ||
| ",5,[5] | ||
| ",https://bandit.readthedocs.io/en/latest/,5,[5] | ||
|
|
||
| .. versionadded:: 0.11.0 | ||
|
|
There was a problem hiding this comment.
Can you add
.. versionchanged:: 1.5.0
New field `more_info` added to output
Since this is a new column and may affect those that are parsing
Patch set adds more_info URL to the csv formatter. Closes: PyCQA#323 Signed-off-by: Tin Lam <tin@irrational.io>
…csv-links Signed-off-by: Tin Lam <tinlam@gmail.com>
ghugo
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch set adds more_info URL to the csv formatter.
Closes: #323
Signed-off-by: Tin Lam tin@irrational.io