Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin to check for ignoring host keys #374

Merged
merged 1 commit into from
Aug 28, 2018
Merged

New plugin to check for ignoring host keys #374

merged 1 commit into from
Aug 28, 2018

Conversation

rajathagasthya
Copy link
Contributor

This new plugin adds a check that detects whether some code using
paramiko is ignoring the host key verification. Ignoring a host
key is the equivalent of ignoring a certificate as part of the
TLS protocol.

Original author: Eric Brown browne@vmware.com

Fixes Issue: #357

:Example:


.. versionadded:: 1.5.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the next release is 1.5.1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 1.5.1 seems reasonable.

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need a new file in doc/source/plugins/b507_ssh_no_host_key_verification.rst

:Example:


.. versionadded:: 1.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 1.5.1 seems reasonable.

This new plugin adds a check that detects whether some code using
paramiko is ignoring the host key verification.  Ignoring a host
key is the equivalent of ignoring a certificate as part of the
TLS protocol.

Original author: Eric Brown <browne@vmware.com>

Fixes Issue: #357
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit 0293e9d into PyCQA:master Aug 28, 2018
@rajathagasthya rajathagasthya deleted the no-host-keys branch August 28, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants