Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inclusion of pip in pyproject.toml causing failed builds #91

Closed
grgmiller opened this issue Jul 8, 2022 · 2 comments
Closed

Inclusion of pip in pyproject.toml causing failed builds #91

grgmiller opened this issue Jul 8, 2022 · 2 comments
Labels
bug This issue/PR relates to a bug.

Comments

@grgmiller
Copy link
Contributor

Per pypa/pip#11120, including pip in pyproject.toml [build-system] requires causes failures when trying to install doc8.

I've been experiencing this issue as described catalyst-cooperative/pudl#1742 (comment), when pre-commit is trying to install the virtual environment that includes doc8.

I think that if pip were removed from your toml file, it would likely solve this issue.
@grgmiller grgmiller mentioned this issue Jul 12, 2022
Closed
@ssbarnea
Copy link
Member

@grgmiller Yep, please make a PR to fix it. In fact it would be good idea to update the packaging pipeline to use "build" module too.

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Jul 26, 2022
grgmiller added a commit to grgmiller/doc8 that referenced this issue Jul 26, 2022
@grgmiller
Remove pip from pyproject.toml
8261b48 
In response to PyCQA#91 (comment)
@grgmiller grgmiller mentioned this issue Jul 26, 2022
Merged
ssbarnea added a commit that referenced this issue Jul 27, 2022
@grgmiller @ssbarnea
Remove pip from pyproject.toml (#94)
30e8034 
In response to #91 (comment)

Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ssbarnea
Copy link
Member

Fixed by #94, release very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssbarnea @grgmiller