Add travis-lint #35
Closed
Add travis-lint #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivial changes highlighted by my editor. We can/should configure pre-commit to do this in the future. Change-Id: Ib62be1ce61bb73702db8b31fc1a9b1fb8e806a36 Signed-off-by: Stephen Finucane <stephen@that.guru>
- exclude running jobs on tags - perform linting of travis file - remove credentials, easier to manage via web Change-Id: Iafa4a5ef0404b18fa8b2dcb1553d5f9aaed6c92b
|
@stephenfin should we get in sync on irc about addressing chores on doc8? My nick is "zbr" there. |
ssbarnea
approved these changes
Jun 2, 2020
Yup. stephenfin there too. Talking about this PR specifically, it seems the gem installation still isn't functioning correctly. I simply rebased the change and stripped out the README rework so I'm not sure where to start with this. Care to take a look? |
|
Closing it as no longer needed once we switch to github actions, faster, more reliable and easier to maintain. I am almost done with migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the Travis-related contents of #29.