B902: Add exceptions for standard library metaclasses (#415)

I faced a false positive when deriving my metaclass from ABCMeta, which should be fixed with this commit. I also added EnumMeta to this list, because it was the only other public metaclass in the standard library.
PyCQA · Nov 26, 2023 · cfc2429 · cfc2429
1 parent 393fea1
commit cfc2429
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bugbear.py b/bugbear.py
@@ -1046,7 +1046,7 @@ def is_classmethod(decorators: Set[str]) -> bool:
             return
 
         bases = {b.id for b in cls.bases if isinstance(b, ast.Name)}
-        if "type" in bases:
+        if any(basetype in bases for basetype in ("type", "ABCMeta", "EnumMeta")):
             if is_classmethod(decorators):
                 expected_first_args = B902.metacls
                 kind = "metaclass class"

diff --git a/tests/b024.py b/tests/b024.py
@@ -92,7 +92,7 @@ def method(self):
 
 
 class non_keyword_abcmeta_1(ABCMeta):  # safe
-    def method(self):
+    def method(cls):
         foo()