(3.8) Minor tweaks #368
Merged
(3.8) Minor tweaks #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperlees
approved these changes
Mar 16, 2023
| @@ -747,8 +747,7 @@ def test_selfclean_bugbear(self): | |||
| filename = Path(__file__).absolute().parent.parent / "bugbear.py" | |||
| proc = subprocess.run( | |||
| ["flake8", str(filename)], | |||
| stdout=subprocess.PIPE, | |||
| stderr=subprocess.PIPE, | |||
| capture_output=True, | |||
There was a problem hiding this comment.
O, TIL, have never used ! NIce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #365
Some minor changes:
bugbear.pyandtest_bugbear.pyfrom runningpyupgrade --py38-plusagainst them (I left the individual test files, not sure if we want to change those)pyproject.tomlsettingrequires-pythonto>=3.8.1instead of>=3.8to match flake8tox.inion (3.8) Update CI and metadata #367Should we also change the
flake8dependency requirement from>=3.0.0to>=6.0.0?