fix(b038): Restrict rule to mutating functions only #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation produced false positives. This fixes those and adds some more tests. See PyCQA#451
cooperlees
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Sounds good to me and sage way to start hardening it.
Will let a few more eyes see it, and release later today.
Appreciate the prompt action, considering I didn't let you know when I was releasing it. I should do that moving forward too with new contributions like this.
|
No worries, I just had an hour in between things just now and this perfectly filled it 🙂 I will look into a good way to harden it further tomorrow and write up a proposal in an issue then. |
JelleZijlstra
approved these changes
Jan 17, 2024
|
FYI, I've outlined the proposal on how to harden the rule of B038 further in #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation produced false positives.
This fixes those and adds some more tests.
Fixes #451
@cooperlees this fixes the bugs described in the issue - There are some more mutating functions (like a
dict.popitem()=and*=and+=are still left to do) that I won't have time to add today.That said, this will only cause false negatives, so I figured I'd push this and create the PR so you can release a fix for the FPs.