Do not emit Y053 for the argument to @deprecated() #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change has no effect on typeshed. 🤖🎉 |
JelleZijlstra
commented
Nov 8, 2023
| @@ -308,6 +308,9 @@ def _is_object(node: ast.AST | None, name: str, *, from_: Container[str]) -> boo | |||
| _is_BaseException = partial(_is_object, name="BaseException", from_={"builtins"}) | |||
| _is_TypeAlias = partial(_is_object, name="TypeAlias", from_=_TYPING_MODULES) | |||
| _is_NamedTuple = partial(_is_object, name="NamedTuple", from_=_TYPING_MODULES) | |||
| _is_deprecated = partial( | |||
There was a problem hiding this comment.
This name is a little confusing. I considered _is_at_deprecated or _is_deprecated_decorator, but not sure that's much better. Note that we already have _is_final and _is_unused which have similar issues.
srittau
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443