Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make --ignore order consistent #1552

Merged
merged 1 commit into from Feb 6, 2022
Merged

make --ignore order consistent #1552

merged 1 commit into from Feb 6, 2022

Conversation

asottile
Copy link
Member

@asottile asottile commented Feb 6, 2022

for #1550

I think this is worth doing anyway -- though we should reconsider whether showing the configured values as "default" in --help is desirable or not

@asottile asottile merged commit 62ce3e4 into main Feb 6, 2022
@asottile asottile deleted the ignore-order branch February 6, 2022 16:39
@sigmavirus24
Copy link
Member

I believe I used a set because someone complained about having a long list of plugins which ended up including duplicates and the performance hit of checking the same code more than once. I was trying to deduplicate things without having to worry about checking if it was already present or keep 2 copies of things. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants