100% test coverage for new identify module

PyCQA · Dec 31, 2020 · 8e70db8 · 8e70db8
1 parent 0383c36
commit 8e70db8
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 9 deletions.
diff --git a/isort/identify.py b/isort/identify.py
@@ -74,7 +74,7 @@ def imports(
                     break
 
                 stripped_line = next_line.strip().split("#")[0]
-            continue
+            continue  # pragma: no cover
 
         line, *end_of_line_comment = raw_line.split("#", 1)
         statements = [line.strip() for line in line.split(";")]
@@ -88,7 +88,7 @@ def imports(
             elif line.startswith("from "):
                 type_of_import = "from"
             else:
-                continue
+                continue  # pragma: no cover
 
             import_string, _ = parse_comments(line)
             normalized_import_string = (
@@ -135,13 +135,15 @@ def imports(
                                 break
                             line, _ = parse_comments(next_line)
                             import_string += "\n" + line
-
-                    if import_string.strip().endswith(
-                        (" import", " cimport")
-                    ) or line.strip().startswith(("import ", "cimport ")):
-                        import_string += "\n" + line
                     else:
-                        import_string = import_string.rstrip().rstrip("\\") + " " + line.lstrip()
+                        if import_string.strip().endswith(
+                            (" import", " cimport")
+                        ) or line.strip().startswith(("import ", "cimport ")):
+                            import_string += "\n" + line
+                        else:
+                            import_string = (
+                                import_string.rstrip().rstrip("\\") + " " + line.lstrip()
+                            )
 
             if type_of_import == "from":
                 import_string = (

diff --git a/tests/unit/test_identify.py b/tests/unit/test_identify.py
@@ -2,6 +2,7 @@
 from typing import List
 
 from isort import Config, identify
+from isort.identify import Import
 
 
 def imports_in_code(code: str, **kwargs) -> List[identify.Import]:
@@ -219,12 +220,37 @@ def test_complex_examples():
 from os (
     import path
 )
+from os import \\
+    path
+from os \\
+    import (
+        path
+    )
 from os import ( \\"""
             )
         )
-        == 7
+        == 9
     )
     assert not imports_in_code("from os import \\")
+    assert (
+        imports_in_code(
+            """
+from os \\
+    import (
+        system"""
+        )
+        == [
+            Import(
+                line_number=2,
+                indented=False,
+                module="os",
+                attribute="system",
+                alias=None,
+                cimport=False,
+                file_path=None,
+            )
+        ]
+    )
 
 
 def test_aliases():