-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicitly check for first-party #1071
Conversation
Incompatible poetry? Update: Tried a few things and couldn't get it to work. |
This is a breaking change though because it would sort/separate imports differently than today. To address #704 without installing all third party dependencies into virtual, one could configure default to be |
I think this (pwd or specified src directory) is the correct approach and would like to get this in for the 5.0.0 release, thanks for the pull-request! |
Great, thanks! Should I try again to get CI fixed? That feels better to be a separated PR though. |
@timothycrosley ping |
I came across this PR while researching how isort determines whether a package is "first party" vs "third party." Personally, I don't think this is a good way to determine the difference. I have a lot of per-project virtual environments, which I keep inside the project directory in a If the "first party" path could be made configurable (i.e. only things under |
I think this happens after checking for 3rd party. |
Ah, interesting. There must be something else going on that I do not understand, because the only way I have ever managed to get isort to classify anything as "third-party" is to put |
#1147 specifies the desired behaviour change along these lines |
modules under pwd could be identified as first-party instead of default configuration
Codecov Report
@@ Coverage Diff @@
## develop #1071 +/- ##
===========================================
- Coverage 99.95% 99.90% -0.05%
===========================================
Files 32 32
Lines 2028 2030 +2
===========================================
+ Hits 2027 2028 +1
- Misses 1 2 +1 |
modules under pwd could be identified as first-party instead of
default configuration
@timothycrosley wdyt of this?