Add support for glob expansion in src_paths #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glumia
commented
Jun 27, 2021
| @@ -90,7 +90,18 @@ def test_is_supported_filetype_fifo(self, tmpdir): | |||
| def test_src_paths_are_combined_and_deduplicated(self): | |||
| src_paths = ["src", "tests"] | |||
| src_full_paths = (Path(os.getcwd()) / f for f in src_paths) | |||
| assert Config(src_paths=src_paths * 2).src_paths == tuple(src_full_paths) | |||
| assert sorted(Config(src_paths=src_paths * 2).src_paths) == sorted(src_full_paths) | |||
There was a problem hiding this comment.
I assumed the order of src_paths does not matter... does it? 👀
timothycrosley
approved these changes
Jun 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #1766 +/- ##
===========================================
- Coverage 100.00% 99.89% -0.11%
===========================================
Files 37 37
Lines 2930 2930
Branches 694 694
===========================================
- Hits 2930 2927 -3
- Misses 0 2 +2
- Partials 0 1 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1704, this adds support for glob expansion in paths provided with the
src_pathsconfig.