Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #125
This PR contains test cases and fixes for a bug relating to inline comments on
import ... as ...
lines.Examples of the incorrect behavior are (all invocations of
isort
are with default options, i.e.isort -d $file
):Example 1
On 3.9.0 this has its comments stripped; with this PR it is left unchanged.
Example 2
was being converted to (branch
develop
3.9.0)with this PR it is left unchanged.
Note that there is an option
'combine_as_imports'
but it is not (AIUI) exposed to the user in the command line API. If that option is set toTrue
by manually editingisort/settings.py
, we do get the desired output for these examples (one of the test cases confirms this).