Fix black compatibility for .pyi type stub files
#2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
requested changes
Dec 9, 2022
There was a problem hiding this comment.
Thanks for the improvement @XuehaiPan, would you mind also adding tests since you added new logic to the code?
|
@staticdev I update the tests accordingly and they have successfully passed on my local machine. |
staticdev
approved these changes
Dec 10, 2022
|
Thanks @XuehaiPan LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
lines_after_importssettings for.pyitype stub files if profileblackis set. Theblackformatter does not allow>= 2line breaks in.pyitype stub files.Fixes #1976