Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary parentheses, use f-string, rm "object" #2061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwtoews
Copy link

@mwtoews mwtoews commented Dec 22, 2022

These changes were discovered using:

pyupgrade --py37-plus `find . -name "*.py"`

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #2061 (5ed78a8) into main (98390f5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          38       38           
  Lines        3084     3084           
  Branches      745      745           
=======================================
  Hits         3047     3047           
  Misses         26       26           
  Partials       11       11           

Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwtoews great finding, thanks. I would like to add pyupgrade permanently and execute this command on our scripts/lint.sh as another poetry run command. Could you add that to your PR? For that you will also need to do poetry add --dev pyupgrade>=3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants