Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix colors extras #2212

Merged
merged 1 commit into from Dec 12, 2023
Merged

Fix colors extras #2212

merged 1 commit into from Dec 12, 2023

Conversation

staticdev
Copy link
Collaborator

Closes #2211

@staticdev staticdev added the bug Something isn't working label Dec 11, 2023
@staticdev staticdev mentioned this pull request Dec 11, 2023
Closed
bp72
bp72 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@bp72 bp72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

% pip install -e ".[colors]"
% pip freeze
colorama==0.4.6
-e git+ssh://git@github.com/PyCQA/isort.git@5336d7d8a7d0bd88f1a2b9add826e187183ccd69#egg=isort

@staticdev staticdev merged commit 9255bca into main Dec 12, 2023
35 checks passed
@staticdev staticdev deleted the bugfix/#2211-colors-extra branch December 12, 2023 07:14
@adamjstewart adamjstewart mentioned this pull request Dec 12, 2023
Closed
@amarvin
Copy link

amarvin commented Dec 13, 2023 •
edited

Can you publish a new release to PyPI with this change? Would fix some of my CI/CD pipelines, else I'll have to pin to an earlier isort[colors] version.

@staticdev
Copy link
Collaborator Author

Done @amarvin, 5.13.2 is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bp72 bp72 bp72 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install "isort[colors]" no longer installs colorama
3 participants
@staticdev @amarvin @bp72