Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package available but broken for python 3.7 #230

Closed
PoloB opened this issue May 17, 2024 · 4 comments · Fixed by #231
Closed

Package available but broken for python 3.7 #230

PoloB opened this issue May 17, 2024 · 4 comments · Fixed by #231

Comments

@PoloB
Copy link

PoloB commented May 17, 2024

The setup.py allows to install the package for python 3.7 but the package is in fact only compliant with >=3.8.

Here's the relevant traceback:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/flake8/plugins/finder.py", line 296, in _load_plugin
    obj = plugin.entry_point.load()
  File "/usr/local/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 167, in load
    module = import_module(match.group('module'))
  File "/usr/local/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.7/site-packages/pep8ext_naming.py", line 355
    if args and (name := args[0].arg) and not _ignored(name, ignore):
                      ^
SyntaxError: invalid syntax

Should the setup.py be updated to only support >=3.8?

@sigmavirus24
Copy link
Member

The release notes called out that we dropped support for 3.7 but we did forget to update the packaging metadata

@jparise
Copy link
Member

jparise commented May 17, 2024

Version 0.14.1 has the correct Python version requirement.

@PoloB
Copy link
Author

PoloB commented May 18, 2024

Is 0.14.0 still fetched by pip for python 3.7 when no specific version is provided?

@sigmavirus24
Copy link
Member

@PoloB you can use a number of ways to fix this for yourself

pep8-naming < 0.14.0 ; python_version < "3.8"
pep8-naming >= 0.14.0

For example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants