Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive for E124 and E128 #100

Closed
myint opened this issue Jul 1, 2012 · 0 comments
Closed

False positive for E124 and E128 #100

myint opened this issue Jul 1, 2012 · 0 comments
Labels
bug
Milestone
1.3.4

Comments

@myint
Copy link
Member

myint commented Jul 1, 2012 

d = {  # comment
    1: 2
}
$ pep8 a.py
a.py:2:5: E128 continuation line under-indented for visual indent
a.py:3:1: E124 closing bracket does not match visual indentation

Removing the comment makes the problem go away.

d = {
    1: 2
}
$ pep8 a.py
florentx added a commit that referenced this issue Jul 3, 2012
@florentx
Add tests for issue #100.
4c0e2d0
smira pushed a commit to smira/pep8 that referenced this issue Jul 25, 2012
Merge remote-tracking branch 'upstream/master'
e8b0ecf 
* upstream/master: (169 commits)
  Fix false positive E401; issue PyCQA#104.
  Add tests for issue PyCQA#100.
  Fix false positive for continuation line indentation when line contains comments. Closes PyCQA#100
  Fix issue with bpython. Closes PyCQA#101
  Back to development.
  Fix crash, and release 1.3.3; issue PyCQA#98.
  Release version 1.3.2.
  Add E902 errors for IOErrors; issue PyCQA#87.
  Update README.
  A little bit of rewording.
  Revert to the pre-1.2 behavior: --show-pep8 does not imply --first; issue PyCQA#89.
  Fix errors on E121 and E124; issue PyCQA#92.
  Add changelog entries for issue PyCQA#86 and issue PyCQA#91.
  Fix the default configuration path on Windows. Issue PyCQA#95.
  Back to development.
  Allow 'verbose' to be specified in the config file
  Clarify .pep can be located in any parent folder
  Show maximum length in "E501 line too long" error message
  Release version 1.3.1.
  Do not read the configuration when used as a module.
  ...

Conflicts:
	pep8.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.4
Development

No branches or pull requests
2 participants
@florentx @myint