Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxing pyroma constraint #253

Closed
jakirkham opened this issue May 25, 2018 · 3 comments
Closed

Relaxing pyroma constraint #253

jakirkham opened this issue May 25, 2018 · 3 comments

Comments

@jakirkham
Copy link
Contributor

It appears the pyroma constraint is extremely tight ( exactly 2.0.2 ). The commit message seems to suggest this was needed a while back, but is not necessarily still needed now. Could it be relaxed?
@chocoelho
Copy link
Contributor

It required some changes, but it's working now. Releasing a new patch soon.

@jakirkham
Copy link
Contributor Author

Thank you :)

jakirkham referenced this issue May 26, 2018
@chocoelho
Update pyroma support
d0c416a 
Some 'breaking changes' here. Pyroma no longer provides TestSuite ratings,
see https://github.com/regebro/pyroma/commit/4199479fa0df7de2c0d907458e6af888a9897045\#diff-e59624df44e0bd8d01fdfa6baea1e0e2

Also PEP386Version became PEPVersion on https://github.com/regebro/pyroma/commit/505f5aba92d270e7badc9b8aa3aff05930d11bf1\#diff-e59624df44e0bd8d01fdfa6baea1e0e2

Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
@jakirkham
Copy link
Contributor Author

Had a follow-up question when you have a chance to look.

@jakirkham jakirkham mentioned this issue May 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakirkham @chocoelho