Release 1.1.6 #295
Merged
Release 1.1.6 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a [pre-commit](https://pre-commit.com)-hook for running Prospector against all changed Python files of a git commit.
…encies in list of used libraries
Add a pre-commit hook for running Prospector
Adding pylint plugins back to fix --uses and --autodetect
…c separator rather than OS specific path separator
|
@chocoelho FYI I also changed the threshold for failure on coveralls to a change of 1% so we don't get "failed" PRs due to a 0.04% change in coverage... |
More generic path separator for --output-format output files
chocoelho
approved these changes
Nov 22, 2018
djpugh
reviewed
Nov 22, 2018
| splitted_value = value.split(pathsep) | ||
| output_format, output_targets = splitted_value[0], splitted_value[1:] | ||
| parsed = re.split(r'[;:]', value) | ||
| output_format, output_targets = parsed[0], parsed[1:] |
There was a problem hiding this comment.
I think this raises another issue least if split by ':' is used on windows and this is still supposed to work with absolute paths as -o xunit:C:\test_results\test.xml will behave unexpectedly i think (not sure how this is used elsewhere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes and also bringing develop and master branch into sync
@chocoelho No big changes here, one small fix and just want to clean up the master/develop differences. I'll merge this myself if you don't have any complaints in the next few days.