Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook for running Prospector #284

Merged
merged 2 commits into from
Nov 18, 2018

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Oct 17, 2018

This adds a pre-commit-hook for running
Prospector against all changed Python files of a git commit.

This adds a [pre-commit](https://pre-commit.com)-hook for running
Prospector against all changed Python files of a git commit.
@coveralls
Copy link

coveralls commented Oct 17, 2018

Pull Request Test Coverage Report for Build 647

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.4%) to 77.234%

Files with Coverage Reduction New Missed Lines %
prospector/exceptions.py 1 85.71%
prospector/message.py 1 77.97%
prospector/tools/pylint/linter.py 1 61.76%
prospector/encoding.py 1 61.11%
prospector/tools/init.py 1 96.15%
prospector/run.py 3 71.43%
Totals Coverage Status
Change from base Build 637: -0.4%
Covered Lines: 1530
Relevant Lines: 1981

💛 - Coveralls

@carlio
Copy link
Member

carlio commented Oct 17, 2018

I do like this, I use pre-commit all the time.

One request - could you add to the docs / README how to use it? There are lots of configuration options and in fact an old issue related to this - #56

@carlio carlio changed the base branch from master to develop November 18, 2018 12:18
@carlio carlio merged commit c7f82b4 into landscapeio:develop Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants