Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #543

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 1, 2022

@Pierre-Sassoulas @carlio
Some magic was done for pathlib in Python 3.10 but it seems to no longer be needed in Python 3.11.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the dependencies
  • I have updated the dependencies accordingly
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.9.0 milestone Dec 1, 2022
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you for fixing the duplicated jobs too ! I think this warrant a release. Could you upgrade the metadata in setup.cfg and maybe add a quick changelog entry for python 3.11 support ?

@cclauss cclauss changed the title pathlib._NormalAccessor only exists in Python 3.10 Add support for Python 3.11 Dec 1, 2022
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 1.9.0, 1.8.1 Dec 1, 2022
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit 24de8af into landscapeio:master Dec 1, 2022
@Pierre-Sassoulas
Copy link
Collaborator

I wanted to release 1.8.1 with python 3.11 support but it seems like the release pipeline was not launched when I published 1.8.0 on github. Maybe a right issue ? Could you check @carlio ? I've created the 1.8.1 tag too, We need to launch the release pipeline for 1.8.0 and copy paste the changelog and create the release in github for 1.8.1 :)

@cclauss cclauss deleted the patch-1 branch December 1, 2022 11:37
@carlio
Copy link
Member

carlio commented Dec 1, 2022

@Pierre-Sassoulas I believe that you have to manually run the Release action. I don't know as I didn't set that up myself, I just push from my local code :-)

@carlio
Copy link
Member

carlio commented Dec 1, 2022

@Pierre-Sassoulas
Copy link
Collaborator

Yeah, I'm the one who set it up 😄 The pipeline should be launched by a manual github release. Well, let me debug that then.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 1, 2022

You might want to change https://github.com/PyCQA/prospector/blob/master/.github/workflows/release.yml#L1-L6 to run on demand by using workflow_dispatch so that releases must always be done manually but execute the same steps each release.

@Pierre-Sassoulas
Copy link
Collaborator

Hmm, maybe but the same code is running fine in pylint so I don't think this is the issue. This is what I'm seeing in the github actions workflow:

releaseworkflow

Do you have something different with 1.8.0 being visible and possible to launch @carlio ?

@Pierre-Sassoulas
Copy link
Collaborator

Very strange, 1.8.1 launched automatically: https://github.com/PyCQA/prospector/actions/runs/3592595098.

@Pierre-Sassoulas
Copy link
Collaborator

And it's released : https://pypi.org/project/prospector/#history

I'm not sure if it's worth it debug to be able to release 1.8.0 now.

@carlio
Copy link
Member

carlio commented Dec 1, 2022

I did nothing. All I can guess is that 1.8.0 < 1.8.0rc1 and so didn't trigger the release logic?

@Pierre-Sassoulas
Copy link
Collaborator

Pierre-Sassoulas commented Dec 1, 2022

Possibly 1.8.0rc1 is considered like 1.8.0 and it should have been 1.8.0-rc1 (?) We released a 2.14.0-b1 with the same pipeline before releasing 2.14.0 without issue in pylint.

@carlio
Copy link
Member

carlio commented Dec 1, 2022

I just followed the python release naming scheme for rc. Seems PEP440 doesn't allow - in an rc release - https://peps.python.org/pep-0440/#public-version-identifiers - but tbh doesn't really matter, it's released now ;-)

@Pierre-Sassoulas
Copy link
Collaborator

Yeah it's going to stay a mystery 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants