-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you for fixing the duplicated jobs too ! I think this warrant a release. Could you upgrade the metadata in setup.cfg and maybe add a quick changelog entry for python 3.11 support ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
I wanted to release 1.8.1 with python 3.11 support but it seems like the release pipeline was not launched when I published 1.8.0 on github. Maybe a right issue ? Could you check @carlio ? I've created the 1.8.1 tag too, We need to launch the release pipeline for 1.8.0 and copy paste the changelog and create the release in github for 1.8.1 :) |
@Pierre-Sassoulas I believe that you have to manually run the Release action. I don't know as I didn't set that up myself, I just push from my local code :-) |
Yeah, I'm the one who set it up 😄 The pipeline should be launched by a manual github release. Well, let me debug that then. |
|
Hmm, maybe but the same code is running fine in pylint so I don't think this is the issue. This is what I'm seeing in the github actions workflow: Do you have something different with 1.8.0 being visible and possible to launch @carlio ? |
Very strange, 1.8.1 launched automatically: https://github.com/PyCQA/prospector/actions/runs/3592595098. |
And it's released : https://pypi.org/project/prospector/#history I'm not sure if it's worth it debug to be able to release 1.8.0 now. |
I did nothing. All I can guess is that 1.8.0 < 1.8.0rc1 and so didn't trigger the release logic? |
Possibly |
I just followed the python release naming scheme for rc. Seems PEP440 doesn't allow |
Yeah it's going to stay a mystery 😄 |
@Pierre-Sassoulas @carlio
Some magic was done for
pathlib
in Python 3.10 but it seems to no longer be needed in Python 3.11.Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: