E121, E126 false positives #138

Closed
jianli opened this Issue Nov 9, 2012 · 2 comments

Projects

None yet

2 participants

@jianli

In pep8 v.1.3.3, these two cases are flagged with

E126 continuation line over-indented for hanging indent

{
    1:
        999999 if True
        else 0,
}
[
    12,  # this is a multi-line inline                                                                                                                                                                           
         # comment                                                                                                                                                                                               
]

and the latter also triggers:

E121 continuation line indentation is not a multiple of four

@florentx

The first one is better written:

{
    1: (
        999999 if True
        else 0),
}

The second case looks like a bug.

@florentx florentx closed this Dec 9, 2012
@jianli

@florentx what's the rationale behind rewriting the first one with parentheses? The parentheses aren't syntactically necessary, and they don't make the expression more readable either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment