Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

pep257.py contains PEP-257 errors #2

Closed
dpursehouse opened this issue Jun 20, 2012 · 3 comments
Closed

pep257.py contains PEP-257 errors #2

dpursehouse opened this issue Jun 20, 2012 · 3 comments

Comments

@dpursehouse
Copy link
Contributor

The pep257.py script contains a number of PEP-257 errors which I assume are intended to demonstrate the functionality.

I want to be able to use the script in an environment where all python scripts (including pep257.py itself) will be automatically verified with pep257.py (and pep8.py) but this isn't possible if the script itself fails :)

Would you accept a pull request that removes these errors?

(The necessary changes are already done on my fork but I need to refactor it to break out some other changes to a separate commit)

@keleshev
Copy link
Contributor

I introduced PEP 257 errors as a way to get cheap testing. While development, I would just run pep257.py pep257.py to test and see if it gives warnings I expect.

I will pull your fixes, but you should consider adding some tests then to test_pep257.py. I used py.test to run it.

@dpursehouse
Copy link
Contributor Author

OK, I'll clean up the commits and send a pull request. I'll also try to add some unit test cases.

@dpursehouse
Copy link
Contributor Author

This is handled in #3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants