Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project metadata #17

Merged
merged 1 commit into from Apr 17, 2015
Merged

Update project metadata #17

merged 1 commit into from Apr 17, 2015

Conversation

bitglue
Copy link
Member

@bitglue bitglue commented Apr 17, 2015

Point people to GitHub, not Launchpad. All that's left on Launchpad are
a bunch of stale bugs.

Update the author field to reflect the large number of contributors.
Remove the maintainer field because a bug in something (setuptools?)
overwrites the author field with the maintainer field when the package
gets uploaded to PyPI.

Point people to GitHub, not Launchpad. All that's left on Launchpad are
a bunch of stale bugs.

Update the author field to reflect the large number of contributors.
Remove the maintainer field because a bug in something (setuptools?)
overwrites the author field with the maintainer field when the package
gets uploaded to PyPI.
@bitglue bitglue merged commit c5d8e42 into PyCQA:master Apr 17, 2015
@myint
Copy link
Member

myint commented Apr 17, 2015

Can the GitHub issues page be enabled in this repository?

@bitglue
Copy link
Member Author

bitglue commented Apr 17, 2015

@myint planning on it, as soon as I bug @florentx to add me to the launchpad project so I can clean that out.

@myint
Copy link
Member

myint commented Jul 10, 2015

@bitglue, ping?

@bitglue
Copy link
Member Author

bitglue commented Jul 10, 2015

Sorry, forgot about this thread. I did get access to Launchpad and did some grooming on the backlog there, but there's more to be done for sure. Would you like to help? If so, I can probably delegate the necessary privileges on GitHub and Launchpad to you.

@sigmavirus24
Copy link
Member

@bitglue I'm happy to help as well.

@bitglue
Copy link
Member Author

bitglue commented Jul 10, 2015

@myint @sigmavirus24 I've invited both of you to the Pyflakes organization on Github. It looks like we need some adjustment to the Launchpad permissions to allow you to do everything in the bug tracker, so I've reached out to @florentx for that, since he's the administrator there.

@myint
Copy link
Member

myint commented Jul 10, 2015

Sounds good.

Thanks

@sigmavirus24
Copy link
Member

@bitglue do we want to migrate the issues from LaunchPad to here? I can write a script to do so. (I've done the opposite direction already in a separate script.)

@bitglue
Copy link
Member Author

bitglue commented Jul 14, 2015

It couldn't hurt. Besides the bug tracker, I don't think Launchpad is doing anything useful. If we migrate that, then we only need to maintain one thing.

@myint
Copy link
Member

myint commented Jan 17, 2016

There seems to be an existing Launchpad-to-GitHub issue converter:

There is a recent pull request in that repository, which makes me think that the above still works with Launchpad.

@myint
Copy link
Member

myint commented May 15, 2017

It's been over a year, but I finally tried exporting the issues from Launchpad using lp2gh.

https://gist.github.com/myint/df7b7f6a537a19b5a813a6d8b3cec52c

If someone enables the issues, I can use the same lp2gh tool to import the issues from the above JSON into this repository.

Here is a test import I did using a temporary repository:

https://github.com/myint/pyflakes-test-again/issues

@myint
Copy link
Member

myint commented May 15, 2017

Note that Launchpad lists 53 open issues, but 2 of them actually have fixes committed. They were just left open. So it is correct for my test repository to have only 51 issues.

@jayvdb
Copy link
Member

jayvdb commented May 15, 2017

I've marked those two as 'Fix released'

@jayvdb
Copy link
Member

jayvdb commented May 15, 2017

The importer does add back ticks around __future__, and maybe some other conversions problems. 51 issues is low enough that IMO it is more sensible to edit the issues after import to fix any minor formatting issues.

@myint
Copy link
Member

myint commented May 17, 2017

One thing I probably want to avoid is using my own account to do the importing. Its fine for the temporary repository since I plan to delete it. But for the real permanent thing, I don't want to clutter up my personal "issues" page.

Pylint used a "bot" account when they imported their issues from BitBucket. I think it would make sense for me to do the same.

https://github.com/pylint-bot

@The-Compiler
Copy link
Member

I did the issue migration there, let me know if I can help somehow. Using a bot account (with an alternative mail - if you have a gmail address, you should be able to use yourmail+somelabel@gmail.com) worked out fine.

@myint
Copy link
Member

myint commented May 18, 2017

@The-Compiler Thanks! I'll let you know if I run into something.

@myint
Copy link
Member

myint commented May 19, 2017

@bitglue Could you enable "issues" in this repository? Thanks.

@asmeurer
Copy link
Contributor

@myint if you contact GitHub (and are really nice), they may help you do a "true" import, with correct usernames. We did this for sympy/sympy from Google Code a while back (see, e.g., sympy/sympy#6000).

@myint
Copy link
Member

myint commented May 19, 2017

@asmeurer Cool! Hopefully they have support for Launchpad.

@asmeurer
Copy link
Contributor

We had to provide the data to them in their own format. This is the script we used (I believe one of the branches on that repo).

@myint
Copy link
Member

myint commented May 19, 2017

I'm guessing that would be themy2 branch since it contains a new script:

https://github.com/skirpichev/google-code-issues-migrator/blob/my2/exportissues.py

It looks like that eventually got merged into a newer fork (abusalimov/google-code-issues-migrator#1):

https://github.com/abusalimov/google-code-issues-migrator/blob/master/exportissues.py

The script outputs JSON files. Though, I didn't find any comments explicitly saying this was a format GitHub would accept.

@myint
Copy link
Member

myint commented May 21, 2017

I just asked GitHub and got an immediate response from Shawna. They have an API for importing issues now. I think the sympy/sympy import happened years before this was released.

https://gist.github.com/jonmagic/5282384165e0f86ef105

It preserves the issue and comment dates. And it doesn't trigger notifications, so I won't have to worry about spamming watchers even if I add @ mentions.

I'll probably try this out in a test repository in a week or so.

@asmeurer
Copy link
Contributor

Very nice. Good to know.

@myint
Copy link
Member

myint commented May 26, 2017

Okay, here is an updated test using the GitHub import API:

https://github.com/pyflakes-bot/pyflakes-test-with-at/issues

The issues and comments now have their original timestamps. They are owned by the new pyflakes-bot user I created since the API does not allow setting the commenter's username (for security reasons). I mapped the commenter's Launchpad username to their GitHub username where appropriate.

@myint
Copy link
Member

myint commented May 26, 2017

Here is a version with all the closed issues also included. They contain their proper timestamps for when they were closed.

https://github.com/pyflakes-bot/pyflakes-test-with-closed/issues

@myint
Copy link
Member

myint commented May 27, 2017

The user importing the issues needs admin permissions:

https://gist.github.com/jonmagic/5282384165e0f86ef105#general-notes

I tested this out in the pyflakes-test organization. I gave pyflakes-bot admin permissions, ran my import script as pyflakes-bot, and then removed pyflakes-bot's permissions.

https://github.com/pyflakes-test/issue-import-test/issues

@sigmavirus24
Copy link
Member

@myint if you're ready to do this, I can manage the permissions wrangling etc.

@myint
Copy link
Member

myint commented May 27, 2017

Great! I'm free right now.

@sigmavirus24
Copy link
Member

Sorry @myint, I wasn't paying attention to this issue or my email. Let's schedule a time to do it? Perhaps it'd be easier to just email me with your availability so we don't spam folks here. We can report back with the final date/time

@myint
Copy link
Member

myint commented May 28, 2017

https://github.com/PyCQA/pyflakes/issues

As @jayvdb mentioned, since the Launchpad issues do not use Markdown, there are some formatting issues in the conversion like __future__ turning into bold future. I did a search and replace where obvious/easy. But there are probably some formatting issues that we may want to fix manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants