Run pyflakes against all code in the virtualenv #69
Conversation
|
Here is what it looks like after #61 is merged: https://travis-ci.org/jayvdb/pyflakes/builds/128447040 |
|
Note that complete log is nicely 'folded'/hidden on Python 3.5+ as it has less flakes and thus fits within the allowed size for the log in the Travis web UI. |
jayvdb
force-pushed
the
travis-check-installed
branch
from
6ba14c7
to
a0d3f86
Compare
|
just rebased. |
|
Can you explain why this is necessary? I feel like this is going to add a lot of noise in the travis logs. |
|
The answer to the "why" question should probably go in the commit log message for posterity |
|
It would have blocked both of the regressions that occurred in 1.2 . |
|
@bitglue is correct. The why for this should be in the commit log and the file should have a comment telling people this is meant to prevent regressions that will only be caught on Travis (not locally). That comment will ideally cause people to look at the commit log and see your reasoning for this. |
|
I'm planning to make an actual framework for tracking differences which would obsolete this |
No description provided.