Fix TestMain tests on Windows #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the API test module has failures for TestMain class, added in f008459, on Windows as SysStreamCapturing is in universal newlines mode while its super class IntegrationTests is using a native console stream with newline=os.linesep. Add Appveyor CI script as .appveyor.yml, which can be selected in the Appveyor settings.
| @@ -55,26 +55,50 @@ def __init__(self, lineno, col_offset=0): | |||
|
|
|||
| class SysStreamCapturing(object): | |||
|
|
|||
| """Replaces sys.stdin, sys.stdout and sys.stderr with StringIO objects.""" | |||
| """ | |||
There was a problem hiding this comment.
Any reason why the first line of the docstring isn't on this line too? PEP 257 recommends it be on one line (not that this project explicitly follows that).
There was a problem hiding this comment.
My understanding is that PEP 257 doesn't recommend either approach for the summary line (same as opening line, or next line).
This code base very obviously uses the latter convention, which is why I have done it.
There was a problem hiding this comment.
Fair. I checked the example in the document and skimmed over the portion where it said it can be written like this or on the same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the API test module has failures for TestMain class,
added in f008459, on Windows as SysStreamCapturing is in
universal newlines mode while its super class IntegrationTests
is using a native console stream with newline=os.linesep.
Add Appveyor CI script as .appveyor.yml,
which can be selected in the Appveyor settings.