Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let pyreverse show abstract methods differently #7346

Closed
dgutson opened this issue Aug 23, 2022 · 3 comments · Fixed by #7436
Closed

Let pyreverse show abstract methods differently #7346

dgutson opened this issue Aug 23, 2022 · 3 comments · Fixed by #7436
Assignees
@qequ
Labels
Enhancement ✨ Improvement to a component pyreverse Related to pyreverse component
Milestone
2.16.0

Comments

@dgutson
Copy link

dgutson commented Aug 23, 2022

Current problem

Currently, there's no way to distinguish abstract methods.

Desired solution

Abstract methods are shown in italic in UML diagrams.
I propose to get that idea and shows @abstractmethod also in italic.
CC @qequ

Additional context

No response
@dgutson dgutson added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Aug 23, 2022
@mbyrnepr2 mbyrnepr2 added pyreverse Related to pyreverse component Enhancement ✨ Improvement to a component and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Aug 26, 2022
@qequ
Copy link
Contributor

qequ commented Sep 6, 2022

@mbyrnepr2 I will work on this feature, please assign it to me

@qequ qequ mentioned this issue Sep 8, 2022
Merged
3 tasks
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.16.0 milestone Sep 8, 2022
Pierre-Sassoulas pushed a commit that referenced this issue Sep 13, 2022
@qequ
Feature italics abstract methods (#7436)
2792539 
Update Pyreverse's dot and plantuml printers to detect when class methods are abstract and show them with italic font.
For the dot printer update the label to use html-like syntax.

Closes #7346

Signed-off-by: Alvaro Frias Garay <alvaro.frias@eclypsium.com>
@dgutson
Copy link
Author

dgutson commented Oct 14, 2022

@Pierre-Sassoulas @mbyrnepr2 did this make it into 2.16?

@mbyrnepr2
Copy link
Member

It did indeed @dgutson! 2.16 isn't released yet but you can keep an eye on the progress here: https://github.com/PyCQA/pylint/milestone/71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qequ qequ

Labels
Enhancement ✨ Improvement to a component pyreverse Related to pyreverse component
Projects
None yet
Milestone
2.16.0
Development

Successfully merging a pull request may close this issue.

Feature italics abstract methods qequ/pylint
4 participants
@Pierre-Sassoulas @dgutson @qequ @mbyrnepr2