Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid false positive for arguments-differ when (*args, **kwargs) idiom is used #1674

Closed
wants to merge 1 commit into from

Conversation

kczapla
Copy link
Contributor

@kczapla kczapla commented Sep 23, 2017

No description provided.

@benf-wspdigital
Copy link

Thanks for this implementation.

Please write a proper commit message: the message should describe what the change is. (You can also mention “fixes issue #NNN”, but do that after describing what the change does.)

Please write a description on this request; edit the first message and describe what this request is and why it should go in.

Please address the failures of automated checks.

@rogalski rogalski changed the title Fixes i1553 Avoid false positive for arguments-differ when (*args, **kwargs) idiom is used Nov 2, 2017
@PCManticore
Copy link
Contributor

Thank you for the PR @kczapla . As @benf-wspdigital mentioned, this would also need some tests to make sure this change makes sense. In the meantime I'm closing this PR. Feel free to resubmit once you have a more fleshed out PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants