-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin to astroid 2.1.0 since 2.2.0 can break users #2774
Conversation
Thanks, but as mentioned in the linked issue, this release is supposed to be using 2.2+. |
Can you please confirm whether pylint adheres to semver? If so, my understanding is that if a project upgrades a dependency to a version that can cause a breaking change, the project should bump its major version to indicate this. In any case, what are users who were broken by this supposed to do to make sure they stay on a compatible version of transitive deps pulled in via pylint? I'm manually pinning to astroid 2.1.0 to work around this but if semver is adhered to it shouldn't be necessary to specify any transitive deps. |
astroid 2.2.0 is also breaking everything in our setup. Manually pinning it to astroid 2.1.0 fixed the problem, but it's very annoying to have broken dependencies in pylint. I would strongly suggest to re-open the issue, as it seems to be affecting several users. |
@jab I just released pylint 2.2.2 which restricts the version of Regarding semver and
|
@PCManticore awesome. But you mean |
@bj00rn Yes, you are right, that's 2.2.3 |
See e.g. pylint-dev/astroid#651