-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regexs for bad- and good-names to enable better white- or blacklisting #3186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Germandrummer92
Thank you for your PR! Overall looks good, but there are some things to improve before getting this in.
2a13178
to
a238c75
Compare
@PCManticore Fixed all your comments, thanks! I was wondering: I personally think the config keys |
Hey @Germandrummer92 The current names are fine. While we could change them, we currently don't have a mechanism for deprecation of options like you mentioned (we do have for check messages though). |
Thanks a lot for the PR! 😄 |
Steps
doc/whatsnew/<current release.rst>
.Description
Adds two new config options: bad-names-rgxs and good-names-rgxs, to enable easier white/blacklisting of names.
Type of Changes
| ✓ | ✨ New feature |
Related Issue
Closes #3086