Fix IsADirectoryError in tests/lint/unittest_lint #4781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can add yourself to the contributor, yes :) No need to modify the changelog though. |
paper42
force-pushed
the
fix-test-isadirectoryerror
branch
from
a824f4f
to
55a2e29
Compare
pylintd is a directory, so os.remove throws IsADirectoryError
cdce8p
added a commit
to cdce8p/pylint
that referenced
this pull request
Aug 1, 2021
Squashed commit of the following: commit 49c4bba Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Sun Aug 1 19:56:51 2021 +0800 Fix crash for `unused-private-member` when there are nested attributes commit 2ad8247 Merge: 8ceb26d 1d09bc8 Author: yushao2 <36848472+yushao2@users.noreply.github.com> Date: Sun Aug 1 20:13:05 2021 +0800 Merge pull request pylint-dev#4709 from yushao2/fix-unused-private-member-4673 [unused-private-member] add logic for checking nested functions commit 1d09bc8 Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Sun Aug 1 20:03:42 2021 +0800 update pr based on review commit a4198cd Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Sun Aug 1 19:21:36 2021 +0800 Update pr based on review commit c8b2cbb Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Sun Jul 25 05:20:42 2021 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 4ffea0b Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Sun Jul 25 13:12:29 2021 +0800 Update pr based on review commit e4d6243 Author: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Date: Sun Jul 18 17:23:31 2021 +0200 Remove empty line commit cce5833 Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Sun Jul 18 22:40:54 2021 +0800 update PR based on comments commit 712dc2b Author: Yu Shao, Pang <p.yushao2@gmail.com> Date: Wed Jul 14 16:42:25 2021 +0800 [unused-private-member] add logic for checking nested functions also, improve error message for nested functions commit 8ceb26d Author: Michal Vasilek <michal@vasilek.cz> Date: Sun Aug 1 08:14:58 2021 +0200 Fix IsADirectoryError in tests/lint/unittest_lint (pylint-dev#4781) pylintd is a directory, so os.remove throws IsADirectoryError commit a31e6bc Author: Pierre Sassoulas <pierre.sassoulas@gmail.com> Date: Sat Jul 31 11:21:46 2021 +0200 Add documentation for useless-suppression Closes pylint-dev#4757 commit b71be8a Author: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com> Date: Fri Jul 30 20:21:02 2021 +0200 Handle has-a relationships for type-hinted arguments in class diagrams (pylint-dev#4745) * Pyreverse - Show class has-a relationships inferred from type-hints Closes pylint-dev#4744 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> commit 5e5f48d Author: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> Date: Thu Jul 29 23:44:30 2021 +0200 Add ``forgotten-debug-statement`` checker (pylint-dev#4771) * Add ``no-breakpoint`` checker this adds a checker for calls to ``breakpoint()``, ``pdb.set_trace()``, or ``sys.breakpointhook()``. Closes pylint-dev#3692 Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylintd is a directory, so os.remove throws IsADirectoryError
Do I have to add myself CONTRIBUTORS for a small change like this? Should I add the fix to the changelog?
Type of Changes
Description
Closes #4780