Add forgotten-debug-statement checker

[DanielNoord]

• Add yourself to CONTRIBUTORS if you are a new contributor.
• Add a ChangeLog entry describing what your PR does.
• If it's a new feature, or an important bug fix, add a What's New entry in
  doc/whatsnew/<current release.rst>.
• Write a good description on what the PR does.

Type of Changes

	Type
✓	✨ New feature

Description

This adds a checker for calls to breakpoint() or sys.breakpointhook().
This closes #3692

[coveralls]

Coverage increased (+0.002%) to 92.252% when pulling 07f6167 on DanielNoord:no-breakpoint into a051aa8 on PyCQA:main.

[DanielNoord]

After thinking about this some more:
Do we want to check for redefined functions? And if so, do we want to produce the message even if they are redefined, or do we want to mute the message after redefinition?

[cdce8p]

Do we want to check for redefined functions? And if so, do we want to produce the message even if they are redefined, or do we want to mute the message after redefinition?

That should be covered with inference. You could add an example for it to the test.

[DanielNoord]

That should be covered with inference. You could add an example for it to the test.

I found that the following code passes without throwing the error:

def breakpoint():
    pass
breakpoint()

However, the following code does throw an error.

def overwrite():
    pass
sys.breakpointhook = overwrite
sys.breakpointhook()

I don't think anyone should ever want to overwrite functions like in the second example, but should we consider such code? And if so, much we allow it?

[cdce8p]

However, the following code does throw an error.

def overwrite():
    pass
sys.breakpointhook = overwrite
sys.breakpointhook()

I don't think anyone should ever want to overwrite functions like in the second example, but should we consider such code? And if so, much we allow it?

Tbh I haven't seen anybody reassign stdlib function yet. So I would just ignore that case.

--
I initially though you meant the other way round, i.e. setting an alias. That is common.

b = breakpoint
b()

That should through a no-breakpoint error and can / should be covered by the tests.

[cdce8p]

Just a small last comment

[cdce8p]

LGTM, thanks @DanielNoord!