Issue #117: Fix bug with finding comment node

[gtors]

Added find_iter method, which is became base for find and
find_all methods.

[b5y]

You should start from baron. Take a glance for #95 issue.

[gtors]

Before my changes:

r = RedBaron("""
class X:
    # test
    def __init__(self): 
        pass
""")
r.find('comment') #  None <---------- Wrong! Expected CommentNode here

After my changes:

r = RedBaron("""
class X:
    # test
    def __init__(self): 
        pass
""")
r.find('comment') # '#test' <---------- OK! As expected, CommentNode is found. 

[b5y]

You should add test cases. Without them it is difficult to say something about code. I advise you to check another nodes with find and find_all methods.

[gtors]

But I've added a test cases: https://github.com/PyCQA/redbaron/pull/118/files#diff-38f83afa1ef19109e4de1a26496bc4c9L922

[b5y]

@gtors Okay. In first commit I did not see it.

[bootandy]

Is this getting merged in ? I just encounted a similar comment parsing bug. @b5y

[ibizaman]

Everything looks good. So two things take place in the same commit.
First, refactoring find and find_all in find_iter which is super neat.
Second, fixing the comment issue. Thanks for adding tests for that! But can you link to the exact line(s) in the commit that fixes it? My eye can't find it.

Also, could you add two lines to the CHANGELOG explaining the new find_iter function and the fix as well as adding the find_iter function in the documentation?

[gtors]

But can you link to the exact line(s) in the commit that fixes it? My eye can't find

AFAICR, find and find_all have different behaviors:
L671
L766
The fix was in eliminating these differences.

Also, could you add two lines to the CHANGELOG explaining the new find_iter function and the fix as well as adding the find_iter function in the documentation?

Ok, but as soon as I have some free time.

[ibizaman]

The fix was in eliminating these differences.

Nice catch!

Ok, but as soon as I have some free time.

@gtors no worries, I'll add the changes myself

[Psycojoker]

Fix released https://pypi.python.org/pypi/redbaron/0.6.3