Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elkan, Lloyd, and Hamerly all have duck typing for their metric argument, whereas Yin Yang only accepts
Euclidean
as a distance metric. This tiny pull requests brings the API for Yin Yang in line with Elkan and the others.I am aware that strictly speaking the convergence of KMeans is only guaranteed for the Euclidean distance, but if there is a reason for only allowing
Euclidean
for Yin Yang and not the others, that is not clear to me.