Background in Template not working

[johann-su]

I am having trouble getting the background on boxes to work when using templates.

There is an open issue in the original repo (#151) and a pull request (#74).

An example for reproduction:

from fpdf import Template

elements = [
    # Paper markings
    { 'name': 'marking_1', 'type': 'B', 'x1': 5, 'y1': 105, 'x2': 10, 'y2': 105.5, 'font': None, 'size': 0.0, 'bold': 0, 'italic': 0, 'underline': 0, 'foreground': 0, 'background': '0x000000', 'align': 'I', 'text': None, 'priority': 1, },
    { 'name': 'marking_2', 'type': 'B', 'x1': 5, 'y1': 148.5, 'x2': 10, 'y2': 149, 'font': None, 'size': 0.0, 'bold': 0, 'italic': 0, 'underline': 0, 'foreground': 0, 'background': '0x000000', 'align': 'I', 'text': None, 'priority': 1, },
    { 'name': 'marking_3', 'type': 'B', 'x1': 5, 'y1': 210, 'x2': 10, 'y2': 210.5, 'font': None, 'size': 0.0, 'bold': 0, 'italic': 0, 'underline': 0, 'foreground': 0, 'background': '0x000000', 'align': 'I', 'text': None, 'priority': 1, },
]

# here we instantiate the template and define the HEADER
f = Template(format="A4", elements=elements,
             title="Sample Invoice")
f.add_page()

# and now we render the page
f.render("./template.pdf")

[alexp1917]

it would be good to add this and #205 in the same release. The fix for this issue must contain a test though.

I notice there are some code changes which i do not understand. the default value of background can stay as 65535 instead of 0xFFFFFF. but this bit, for instance:

if pdf.text_color!=rgb(foreground):
  pdf.set_text_color(*rgb(foreground))

that avoids un-necessary pdf syntax from being added to the document, so i would try to keep that unless there's a good reason not to.

It seems like the critical places that we want to change the code (and create tests for) are: lines 140, 164, 167, 173, and lines 186-189 seem like they need review as well.

[Lucas-C]

I opened a PR to fix this: #206

[Lucas-C]

This has just been released in fpdf2.4.3