Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FS.getbasic as it is redundant with current FS.getinfo behaviour #469

Closed
althonos opened this issue Mar 25, 2021 · 0 comments · Fixed by #467
Closed

Deprecate FS.getbasic as it is redundant with current FS.getinfo behaviour #469

althonos opened this issue Mar 25, 2021 · 0 comments · Fixed by #467
Labels
docs Issues related to documentation enhancement
Milestone

Comments

@althonos
Copy link
Member

The FS.getbasic(path) method is supposed to be a shortcut for FS.getinfo(path, namespaces=["basic"]), however every builtin filesystem will provide the basic namespace unconditionally via getinfo. This is even expected in some other places in the code.

In #467 , I updated the FS.getinfo docstring to warn about this behaviour. To go a step further, we should:

  • Deprecate the FS.getbasic method, and have it redirect to FS.getinfo instead
  • Update FSTestCase so that getinfo is expected to produce the basic namespace unconditionally
@althonos althonos added this to the v2.4.13 milestone Mar 25, 2021
@althonos althonos added the docs Issues related to documentation label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to documentation enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant