-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added extract method #127
added extract method #127
Conversation
The code looks good (just had a quick glance), and the use case seems generic enough to be reused in other filesystems. About the name, it could be confusing: |
Good point re the name. I've noticed a pattern that probably dictates the name. We have I think this |
Adds an
extract
method to base, to help with PyFilesystem/s3fs#18It should allow 'downloading' of files without the need for a temp file. The default is a simple file copy loop.
Open to suggestions re naming. Is
extract
appropriate?@althonos