fs.copy.copy_*_if #460
Merged
fs.copy.copy_*_if #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 19, 2021 22:21
The free functions copy_file, copy_file_if_newer, copy_dir, copy_dir_if_newer, copy_fs, and copy_fs_if_newer now are all implemented in terms of copy_file_if, copy_dir_if, and copy_fs_if. Unit Tests for this change will be created in a future commit. This change streamlined the code by removing duplication in logic and clustering similar logic closer together. Also, though this has not been tested, copy_dir_if_newer should be faster in this implementation when copying to a dst_dir that contains a lot of files that are not present in the respective src_dir. Finally, a bug was fixed that was caused by a false lookup in the dictionary of file infos from dst_fs. This fix could cause unnecessary copies and therefore a decrease in performance.
…s.copy. tests/test_copy experienced a general rework in many areas. Before, tests focused on the most basic of test cases and thus missed more complex situations that could (and actually did) cause errors. Thus, some tests for the same unit were merged to create more relevant test cases.
|
Imho, |
|
Nice work! I'll wait for your unit tests to be added. I'm thinking we should soft-deprecate the |
althonos
requested changes
Mar 22, 2021
|
@althonos Thanks. I already added unit tests, I just forgot to remove that part from the description, sorry. It looks like the lines that are not covered anymore are the |
althonos
requested changes
Mar 24, 2021
althonos
approved these changes
Apr 8, 2021
|
Thank you! First PR out of the way 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixes #458
Added _copy_if functions to fs.copy module.
The free functions copy_file, copy_file_if_newer, copy_dir, copy_dir_if_newer, copy_fs, and copy_fs_if_newer now are all implemented in terms of copy_file_if, copy_dir_if, and copy_fs_if.
This change streamlined the code by removing duplication in logic and clustering similar logic closer together.
Also, though this has not been tested, copy_dir_if_newer should be faster in this implementation when copying to a dst_dir that contains a lot of files that are not present in the respective src_dir.
Finally, a bug was fixed that was caused by a false lookup in the dictionary of file infos from dst_fs. This fix could cause unnecessary copies and therefore a decrease in performance.