Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platformdirs instead of appdirs #489

Merged
merged 4 commits into from Mar 13, 2022

Conversation

felixonmars
Copy link
Contributor

@felixonmars felixonmars commented Jul 16, 2021

Type of changes

  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

Use the better maintained platformdirs instead of appdirs.

Use the better maintained `platformdirs` instead of `appdirs`.
@althonos
Copy link
Member

Hi @felixonmars ,

In the current state, I'll have to reject this pull request. platformdirs ~=2.0.2 only supports Python 3, while we try to maintain Python 2.7 compatibilty before the next major release. Maybe try to use conditional specifier for Python2.7 using an older version, if possible?

@althonos althonos self-assigned this Jul 16, 2021
@coveralls
Copy link

coveralls commented Jul 16, 2021

Coverage Status

Coverage remained the same at 95.235% when pulling 15743aa on felixonmars:platformdirs into 196b5f5 on PyFilesystem:master.

@felixonmars
Copy link
Contributor Author

platformdirs ~=2.0.2 only supports Python 3

This is not true. Their Python 3 only version is not yet released, 2.0.2 on PyPI is still compatible with Python 2.

@althonos althonos added this to the v2.4.16 milestone Feb 22, 2022
@althonos althonos merged commit a5954e4 into PyFilesystem:master Mar 13, 2022
@althonos
Copy link
Member

Thank you! Sorry for stalling that for so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants