Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix parsing of FTP LIST command #507

Merged
merged 2 commits into from
Dec 13, 2021
Merged

bug: fix parsing of FTP LIST command #507

merged 2 commits into from
Dec 13, 2021

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Dec 9, 2021

Fixes #506

@adriangb adriangb mentioned this pull request Dec 9, 2021
Closed
@coveralls
Copy link

coveralls commented Dec 10, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 95.244% when pulling 8b91210 on adriangb:ftp-user-regex into 79a7367 on PyFilesystem:master.

althonos
althonos requested changes Dec 10, 2021
View reviewed changes
fs/_ftp_parse.py Outdated Show resolved Hide resolved
@althonos
Copy link
Member

Nice job! Could you please update the CHANGELOG.md and CONTRIBUTORS.md files as well?

@adriangb
Copy link
Contributor Author

Nice job! Could you please update the CHANGELOG.md and CONTRIBUTORS.md files as well?

Done. I ended up first in the contributors list 😅 .

@adriangb
Copy link
Contributor Author

Apologies @althonos, I had made a branch off of my branch for internal use since this one will be deleted when this gets merged, so logically I committed to the wrong branch 🙃. I just pushed the changes mentioned above.

@althonos althonos merged commit 7f19638 into PyFilesystem:master Dec 13, 2021
@althonos
Copy link
Member

Perfect, thanks!

lurch
lurch reviewed Dec 13, 2021
View reviewed changes
CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## Unreleased

- Support more leniant usernames and group names in FTP servers [#507](https://github.com/PyFilesystem/pyfilesystem2/pull/507). Closes [#506](https://github.com/PyFilesystem/pyfilesystem2/pull/506).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late for this PR, but perhaps you could fix 'leniant' -> 'lenient' in your next PR? 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget that, @althonos has already fixed it in #510 ! 🎉 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, thank you @althonos!

@adriangb adriangb deleted the ftp-user-regex branch December 13, 2021 19:45
@adriangb
Copy link
Contributor Author

adriangb commented Feb 4, 2022

Hi @althonos , is there any chance you can cut a release with this change? Thanks!

@althonos
Copy link
Member

althonos commented Feb 7, 2022

@adriangb : done now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@althonos althonos althonos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: FTPFS incorrectly parses results of LIST command
4 participants
@adriangb @coveralls @althonos @lurch