Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

officially support python 3.11 #498

Merged
merged 2 commits into from
Nov 21, 2022
Merged

officially support python 3.11 #498

merged 2 commits into from
Nov 21, 2022

Conversation

dbkeitel
Copy link
Collaborator

@dbkeitel dbkeitel commented Nov 7, 2022

LALSuite on PyPI is available for it since 7.11 last week, so let's see if we pass.

@dbkeitel dbkeitel added the dependencies related to external dependencies label Nov 7, 2022
@dbkeitel
Copy link
Collaborator Author

dbkeitel commented Nov 7, 2022

@Rodrigo-Tenorio requires a look into this:

FAILED PyFstat/tests/test_utils/test_cli.py::test_run_commandline_lal_noerror - AssertionError: assert '/opt/hostedt...s new_path:\n' == ''
  + /opt/hostedtoolcache/Python/3.11.0/x64/bin/lalpulsar_version:5: DeprecationWarning: path is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.

/assign @Rodrigo-Tenorio

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #498 (eaf1744) into master (5ded4a6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   73.74%   73.74%           
=======================================
  Files          22       22           
  Lines        4354     4354           
=======================================
  Hits         3211     3211           
  Misses       1143     1143           
Flag Coverage Δ
unittests 73.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb73896...eaf1744. Read the comment docs.

@dbkeitel dbkeitel marked this pull request as ready for review November 21, 2022 16:18
@dbkeitel
Copy link
Collaborator Author

@Rodrigo-Tenorio review here is less "check the diff" than "check if any diff is missing". ;)

- If more than one version, add 3.11
- If only one, up that to 3.10 (don't trust 3.11 yet).
Copy link
Collaborator

@Rodrigo-Tenorio Rodrigo-Tenorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept my changes

@dbkeitel dbkeitel merged commit 8d8b992 into master Nov 21, 2022
@dbkeitel dbkeitel deleted the python3.11 branch November 21, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies related to external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants