New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make Repository class sortable #2194

Open

underrobyn opened this issue Mar 3, 2022 · 0 comments

underrobyn commented Mar 3, 2022 •

edited

I would like to be able to sort a list of Repository classes like so:

g = Github(getenv('GITHUB_TOKEN'))
org = g.get_organization(getenv('GITHUB_ORG_NAME'))

for repo in org.get_repos():
    repo_list.append(repo)

repo_list.sort()

Doing so results in an error as the Repository class does not implement comparison methods.

The class must define one of __lt__(), __le__(), __gt__(), or __ge__(). In addition, the class should supply an __eq__() method.

Source: https://stackoverflow.com/a/7152650

For the built-in sort method, only __lt__() must be implemented.

I propose the name of the repository should be used for sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment