Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in branch protection rules #2239

Closed
ankitkumar16012000 opened this issue May 24, 2022 · 4 comments · Fixed by #2873
Closed

issue in branch protection rules #2239

ankitkumar16012000 opened this issue May 24, 2022 · 4 comments · Fixed by #2873

Comments

@ankitkumar16012000
Copy link

ankitkumar16012000 commented May 24, 2022

Under branch protection rule GitHub provide Require conversation resolution before merging .
But I am not able to access it through parameters of .edit_protection() (a method of branch object), although I can access other branch protection rules.

@msteiger
Copy link

Maybe #2211 would help you?

@andrewthetechie
Copy link

andrewthetechie commented Jun 17, 2022

There are a couple of parameters missing from edit_protection

required_linear_history
allow_force_pushes
allow_deletions
block_creations
required_conversation_resolution

This is from https://docs.github.com/en/rest/branches/branch-protection#update-branch-protection

@kgal-pan
Copy link

See #2378

@treee111
Copy link
Contributor

There are a couple of parameters missing from edit_protection

required_linear_history allow_force_pushes allow_deletions block_creations required_conversation_resolution

This is from https://docs.github.com/en/rest/branches/branch-protection#update-branch-protection

#2512 writes required_conversation_resolution, I linked a PR that also reads the attribute. After merging, this can be closed in my opinion.
Also the other field in this quote are done than (expect for block_creations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants