Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL API for Enterprise GitHub #2870

Closed
shicholas opened this issue Jan 11, 2024 · 9 comments · Fixed by #2880
Closed

GraphQL API for Enterprise GitHub #2870

shicholas opened this issue Jan 11, 2024 · 9 comments · Fixed by #2880

Comments

@shicholas
Copy link

When using the GraphQL API such as for features like enable_auto_merge, a user should be allowed to specify the URL. AFAICT it's hardcoded https://github.com/PyGithub/PyGithub/blob/603896f44541740d72aa441ed60c698760a1393e/github/Requester.py#L543C81-L543C81

@EnricoMi
Copy link
Collaborator

True, should be configurable like base_url for the REST API. Should be added to github.Github and github.GithubIntegration and passed into github.Requester. Would you mind opening a PR?

@samad-yar-khan
Copy link

@EnricoMi I have been using PyGithub in our project for over a year. If no one is working on this, can I open a PR and try to resolve this issue ?

@EnricoMi
Copy link
Collaborator

@shicholas are you planning to create a PR?

@shicholas
Copy link
Author

@EnricoMi I haven't had the time yet, @samad-yar-khan it's all you, I'll probably need another week then I can look into this.

@EnricoMi
Copy link
Collaborator

@samad-yar-khan go for it, @shicholas happy to get your review when you have time.

@samad-yar-khan
Copy link

@EnricoMi Thanks, I will look into into it and try solving this issue.

@shicholas
Copy link
Author

@samad-yar-khan @EnricoMi threw up a PR, thanks!

@samad-yar-khan
Copy link

samad-yar-khan commented Jan 22, 2024

@shicholas @EnricoMi I couldn't open a PR within time as I was still navigating the code, had some other time constraints and saw a PR already opened for the issue. Thanks for the PRs, went through them to learn a bit about the codebase.

@shicholas
Copy link
Author

thanks so much @EnricoMi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants