BadCredentialsException not raised on GitHub enterprise

[slinkymanbyday]

On Github Enterprise, the API message does not read "Bad credentials" when incorrect credentials are supplied. It reads "Must authenticate to access this API."

Might be better to just go off of the 401 code as opposed to the error message.

if status == 401 and output.get("message") == "Bad credentials":

should be
if status == 401:

[sfdye]

PR please I will review

[Zoom67]

I think this may have broken something. If I run v1.43.2, my script works; if I run 1.43.3, I get 401 {u'documentation_url': u'https://developer.github.com/v3', u'message': u'Bad credentials'}. The credentials are good.

[sfdye]

@Zoom67 Can you share the script?

[Zoom67]

I can share a snippet with some values fudged. It's very simple. Creating this object throws an exception, and the error message contains the JSON above.

from github import Github

class GitConnection(object):
    base_url = 'https://<our-gh-server>/api/v3'
    repo_id = '<repo-name>'

    def __init__(self, username, password):
        self._connection = Github(username, password, self.base_url)
        self._repo = self._connection.get_repo(self.repo_id)

[sfdye]

@Zoom67 Found the culprit #948

This PR changes the relative positions of the arguments, so you might want to use keyword arguments instead of positional ones.

This should solve your problem:
self._connection = Github(username, password, base_url=self.base_url)

[Zoom67]

Yep, that did it - thanks! I changed that line to be fully qualified, just to be sure.

        self._connection = Github(login_or_token=username,
                                  password=password,
                                  base_url=self.base_url)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.