This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
ngIRCd protocol support #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID to ircs2s_common
jlu5
added
type: feature
Closed
Also enable extended server negotiation for ngIRCd, which really just passes 005 between servers (nifty!)
Aside from the 376, none of this is /required/, but it's best to be consistent...
This allows this handler to work natively on ngIRCd.
…ay" warning This fixes a regression from 69cf21c.
(cherry picked from commit 7cfc63d)
ngIRCd sends QUIT after a successful KILL, so trying to remove the target twice is erroneous and will cause a crash. TODO: what happens if an external KILL is never responded to for whatever reason?
Conflicts: protocols/ircs2s_common.py protocols/ts6.py
Also drop the override in protocols/inspircd, as it is no longer needed.
TODO: clean up protocols/unreal to use more of this code as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge yet!This will eventually close #340.Tentative checklist
Get initial connection bits working
Implement handlers
CHANINFOAWAYINVITEJOINKICKKILLPING- needs testing!PRIVMSGMODENICK(client introduction)NICK(nick changes)NOTICEPART- inheritedQUIT- inheritedNJOINSQUITSERVER(ie leaf introductions)TOPICMETADATAImplement commands
_ping_uplink(self)/PONGhandlerspawn_client(self, nick, ident='null', host='null', realhost=None, modes=set(), server=None, ip='0.0.0.0', realname=None, ts=None, opertype=None, manipulatable=False)away(self, source, text)invite(self, source, target, channel)join(self, source, channel)kick(self, source, channel, target, reason=None)kill(self, source, target, reason)knock(self, source, target, text)message(self, source, target, text)- inheritedmode(self, source, target, modes, ts=None)nick(self, source, newnick)notice(self, source, target, text)- inheritednumeric(self, source, numeric, target, text)part(self, client, channel, reason=None)- inheritedquit(self, source, reason)- inheritedsjoin(self, server, channel, users, ts=None, modes=set())spawn_server(self, name, sid=None, uplink=None, desc=None)squit(self, source, target, text='No reason given')topic(self, source, target, text)- inheritedtopic_burst(self, source, target, text)update_client(self, source, field, text)Fill in mode definitions
Fix up outbound mode/njoin wrapping
Figure out how host cloaking works
Complete this checklist