Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MPISecondDerivative #58

Merged
merged 7 commits into from
Aug 6, 2023
Merged

Added MPISecondDerivative #58

merged 7 commits into from
Aug 6, 2023

Conversation

rohanbabbar04
Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 commented Aug 4, 2023 •
edited

  • Added MPISecondDerivative along axis=0.
  • Added tests and updated docs
  • Added derivatives examples for MPIFirstDerivative and MPISecondDerivative.

@rohanbabbar04
Copy link
Collaborator Author

rohanbabbar04 commented Aug 4, 2023 •
edited

  • Calculate along axis=0, as that is the priority
  • Similar to the MPIFirstDerivative...
  • Also added docs...

@mrava87
Copy link
Contributor

mrava87 commented Aug 5, 2023

@rohanbabbar04 thanks! Ill review this tonight :)

mrava87
mrava87 approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@mrava87 mrava87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good :) I just left some minor comment on the text in the example, the rest looks very good

examples/plot_derivative.py Outdated Show resolved Hide resolved
examples/plot_derivative.py Outdated Show resolved Hide resolved
examples/plot_derivative.py Outdated Show resolved Hide resolved
examples/plot_derivative.py Outdated Show resolved Hide resolved
examples/plot_derivative.py Show resolved Hide resolved
pylops_mpi/basicoperators/SecondDerivative.py Show resolved Hide resolved
@rohanbabbar04
Copy link
Collaborator Author

rohanbabbar04 commented Aug 6, 2023 •
edited

Thanks, I have done all the changes and I am merging this PR

@rohanbabbar04 rohanbabbar04 merged commit a7dd516 into main Aug 6, 2023
15 checks passed
@rohanbabbar04 rohanbabbar04 deleted the second-derivative branch August 6, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrava87 mrava87 mrava87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohanbabbar04 @mrava87