Use a dictionary-style interface for setting, adding and getting of attributes of the mesh #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a dictionary-style interface to the mesh class.
Before this PR
After this PR is merged
Question:
Is it maybe better to return the correct shape of the matrix returned by
__getitem__
? It might be more straightforward to use then for the user. In order to implement this feature it is required to keep track of the attributes being vertex, edge, face, voxel attributes, which is not yet there in the class. What do you think, would that make sense?Thank you :)